Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing APIs #777

Closed
wants to merge 1 commit into from
Closed

add missing APIs #777

wants to merge 1 commit into from

Conversation

groverlynn
Copy link
Contributor

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Add APIs that are already available in one form but not exported to the other form

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@lotem
Copy link
Member

lotem commented Dec 17, 2023

The librime 0.9 APIs are deprecated. New API functions added to librime 1.x are not exported as you try to do in this PR.

Would RimeApi do what you want?

@groverlynn
Copy link
Contributor Author

groverlynn commented Dec 19, 2023

The librime 0.9 APIs are deprecated. New API functions added to librime 1.x are not exported as you try to do in this PR.

Would RimeApi do what you want?

Oh, I read the deprecated part wrong. Nvm

@groverlynn groverlynn closed this Dec 19, 2023
@groverlynn groverlynn deleted the api branch December 19, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants