Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

organize APIs #775

Closed
wants to merge 1 commit into from
Closed

organize APIs #775

wants to merge 1 commit into from

Conversation

groverlynn
Copy link
Contributor

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Organize APIs according to the same logical categorization and order in head file and for both versions/formats. Add APIs that are only available in one format also in the other format (except for the deprecated).

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

lotem
lotem reviewed Dec 11, 2023
View reviewed changes
Copy link
Member

@lotem lotem left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are not needed.

By reodering API functions in RimeApi, they break ABI compatiblity.

@lotem lotem closed this Dec 11, 2023
@groverlynn groverlynn deleted the api branch December 12, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lotem lotem lotem left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@groverlynn @lotem