-
Notifications
You must be signed in to change notification settings - Fork 217
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
3 changed files
with
9 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3419f00
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new version doesn't work for me, I went back to 9.17 and it works perfectly, but 9.18 Fails everything.
3419f00
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What didn't works?
3419f00
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be just me, but I tried downloading a few things and whenever it finished checking and started to download the pages it would fail. Basically it went red with the "Try resuming" message playing, but if i tried it would happen again. I just went ahead and downloaded 9.17 again, extracted it over the files and it works perfectly now.
Missing the cool graphic above the download bar though, lol.
3419f00
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's due this code isn't complete yet. I just need to check socket status. 8117be2
This code causing connection to close when timeout reached. I forgot to reset the counter when socket is connected.
Btw, I just checked it seems synapse can handle the timeout without problem. Last time I check synapse using blocking mode on socket, so it's impossible to set timeout without counting the elapsed time manually/. Timeout for connect is hardcoded in communication stack of our operating system. But it seems it have been fixed.
So I revert the commit.
Updates should appear shortly.