Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add effects due to area expansion #81

Merged
merged 20 commits into from
Aug 21, 2024

Conversation

rowancllzz
Copy link
Contributor

@rowancllzz rowancllzz commented Nov 19, 2023

Fixes #58

This pull request implements changes to the two-fluid EBTEL equations to account for cross-sectional area expansion following the methodology of Cargill et al. (2022). This PR represents a substantial modification to ebtel++ and includes the following changes:

  • Add additional input parameters:
    • $L_{TR}/L$ (loop_length_ratio_tr_total)
    • $A_{TR}/A_C$ (area_ratio_tr_coronal)
    • $A_0/A_C$ (area_ratio_0_coronal)
  • Modify derivatives for $p_e$, $p_i$, and $n$
  • Modify $c_1$ calculation to include area expansion effects
  • Modify initial conditions calculation to include area expansion effects
  • Modify velocity calculation to include effects due to area expansion
  • Check that DEM calculations do not need to be modified to account for area expansion (Move to its own issue)
  • Update documentation to include new input parameters
  • Update documentation to include EBTEL equations with area expansion and two fluid effects since these are not published anywhere (Move to its own issue)
  • Add additional tests for different area expansions
  • Confirm that no expansion case here recovers same results as ebtel++ without this PR
  • Add HYDRAD comparison tests for area expansion cases (Move to its own issue)

Additionally, this PR also includes several minor modifications:

  • Update default compiler options to use C++-14 to satisfy Boost Math requirements
  • Move time step control calculations from main() to a separate method on the Loop object

@wtbarnes wtbarnes changed the title Creating a pull request Add effects due to area expansion Nov 20, 2023
@wtbarnes wtbarnes marked this pull request as draft November 20, 2023 20:51
@wtbarnes
Copy link
Member

These files are the spatially-averaged HYDRAD results I've been using for benchmarking. I'm preserving them here to remember what we used to test these new additions against.

no_expansion_electron.txt
no_expansion_ion.txt
no_expansion_single_fluid.txt
q1_tanh_electron_trac.txt
q1_tanh_ion.txt
q1_tanh_single_fluid.txt

@wtbarnes
Copy link
Member

See this gist for an example of some of this benchmarking: https://gist.github.com/wtbarnes/ef4b6401d100399503a956be1d038b5c

@wtbarnes wtbarnes force-pushed the addareaexpansion branch from ca11697 to 6f2a1eb Compare May 7, 2024 17:56
@wtbarnes wtbarnes marked this pull request as ready for review May 9, 2024 01:38
@wtbarnes wtbarnes force-pushed the addareaexpansion branch from ebb9bf2 to cd7868b Compare May 12, 2024 21:56
@wtbarnes
Copy link
Member

I verified that the C++ and IDL results match one another to an acceptable degree and that any remaining differences are not due to this PR. The generic differences between this code and the IDL version are being tracked in #40.

@wtbarnes wtbarnes merged commit 53c5657 into rice-solar-physics:main Aug 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add effects due to area expansion
2 participants