-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add effects due to area expansion #81
Add effects due to area expansion #81
Conversation
These files are the spatially-averaged HYDRAD results I've been using for benchmarking. I'm preserving them here to remember what we used to test these new additions against. no_expansion_electron.txt |
See this gist for an example of some of this benchmarking: https://gist.github.com/wtbarnes/ef4b6401d100399503a956be1d038b5c |
ebb9bf2
to
cd7868b
Compare
cd7868b
to
f260df6
Compare
I verified that the C++ and IDL results match one another to an acceptable degree and that any remaining differences are not due to this PR. The generic differences between this code and the IDL version are being tracked in #40. |
Fixes #58
This pull request implements changes to the two-fluid EBTEL equations to account for cross-sectional area expansion following the methodology of Cargill et al. (2022). This PR represents a substantial modification to ebtel++ and includes the following changes:
loop_length_ratio_tr_total
)area_ratio_tr_coronal
)area_ratio_0_coronal
)Check that DEM calculations do not need to be modified to account for area expansion (Move to its own issue)Update documentation to include EBTEL equations with area expansion and two fluid effects since these are not published anywhere (Move to its own issue)Add HYDRAD comparison tests for area expansion cases (Move to its own issue)Additionally, this PR also includes several minor modifications:
main()
to a separate method on theLoop
object