fix: testing trust manager loop and threshold decrement

src/core/TrustManager.sol

@@ -9,6 +9,8 @@ import { ModuleTypeLib } from "../lib/ModuleTypeLib.sol";
 import { TrustLib } from "../lib/TrustLib.sol";
 import { LibSort } from "solady/utils/LibSort.sol";
 
+import "forge-std/console2.sol";
+
 /**
  * @title TrustManager
  * Allows smart accounts to query the registry for the security status of modules.
@@ -106,7 +108,7 @@ abstract contract TrustManager is IRegistry {
         address attester = $trustedAttesters.attester;
 
         // smart account has no trusted attesters set
-        if (attester == ZERO_ADDRESS || threshold != 0) {
+        if (attester == ZERO_ADDRESS || threshold == 0) {
             revert NoTrustedAttestersFound();
         }
         // smart account only has ONE trusted attester
@@ -125,9 +127,11 @@ abstract contract TrustManager is IRegistry {
                 attester = $trustedAttesters.linkedAttesters[attester];
                 $attestation = $getAttestation({ module: module, attester: attester });
                 if ($attestation.checkValid(moduleType)) threshold--;
+                console2.log("threshold: ", threshold);
                 // if threshold reached, exit loop
                 if (threshold == 0) return;
             }
+            if (threshold > 0) revert InsufficientAttestations();
         }
     }
 

test/TrustDelegation.t.sol

@@ -54,6 +54,27 @@ contract TrustTest is AttestationTest {
         }
     }
 
+    function test_ManyAttesters() public {
+        _make_WhenUsingValidECDSA(attester1);
+        _make_WhenUsingValidECDSA(attester2);
+        Account memory attester3 = makeAccount("attester3");
+        Account memory attester4 = makeAccount("attester4");
+        address[] memory trustedAttesters = new address[](4);
+        trustedAttesters[0] = address(attester1.addr);
+        trustedAttesters[1] = address(attester3.addr);
+        trustedAttesters[2] = address(attester4.addr);
+        trustedAttesters[3] = address(attester2.addr);
+
+        vm.startPrank(smartAccount1.addr);
+        registry.trustAttesters(2, trustedAttesters);
+
+        registry.check(address(module1), ModuleType.wrap(1));
+        registry.check(address(module1), ModuleType.wrap(2));
+        registry.trustAttesters(3, trustedAttesters);
+        vm.expectRevert();
+        registry.check(address(module1), ModuleType.wrap(1));
+    }
+
     function test_WhenSupplyingSameAttesterMultipleTimes() external whenSettingAttester {
         address[] memory attesters = new address[](2);
         attesters[0] = address(attester1.addr);

test/TrustDelegationExternal.t.sol

@@ -5,7 +5,6 @@ import "./Attestation.t.sol";
 import "src/DataTypes.sol";
 import { LibSort } from "solady/utils/LibSort.sol";
 
-
 contract TrustTestExternal is AttestationTest {
     using LibSort for address[];