Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix breaking issue in DefaultBotBuilder #6

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Fix breaking issue in DefaultBotBuilder #6

merged 1 commit into from
Sep 25, 2024

Conversation

rowan-mcalpin
Copy link
Contributor

@rowan-mcalpin rowan-mcalpin commented Sep 24, 2024 •
edited by DragonDev07
Loading

Closes #5

DragonDev07
DragonDev07 approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@DragonDev07 DragonDev07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that!

@DragonDev07 DragonDev07 merged commit ca733cd into rh-robotics:master Sep 25, 2024
1 check passed
@rowan-mcalpin
Copy link
Contributor Author

Thanks for catching that!

There's a chance you'll want to make the build() function public too, I'll test today to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DragonDev07 DragonDev07 DragonDev07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DefaultBotBuilder followTrajectorySequence is private
2 participants
@rowan-mcalpin @DragonDev07