Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Motor Encoder Test #71

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Motor Encoder Test #71

merged 3 commits into from
Jan 18, 2024

Conversation

sadie-datoo
Copy link
Contributor

Tuning and testing motor encoders

@sadie-datoo sadie-datoo requested a review from RZW-13 December 14, 2023 21:47
RZW-13
RZW-13 suggested changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@RZW-13 RZW-13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this (ik I wrote some of it but looking back there's a few things that need to be fixed)

TeamCode/src/main/java/org/firstinspires/ftc/teamcode/auton/Tests/MotorEncoderTest.java Outdated Show resolved Hide resolved
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/auton/Tests/MotorEncoderTest.java Outdated Show resolved Hide resolved
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/auton/Tests/MotorEncoderTest.java Outdated Show resolved Hide resolved
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/auton/Tests/MotorEncoderTest.java Outdated Show resolved Hide resolved
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/auton/Tests/MotorEncoderTest.java Show resolved Hide resolved
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/auton/Tests/MotorEncoderTest.java Outdated Show resolved Hide resolved
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/auton/Tests/MotorEncoderTest.java Outdated Show resolved Hide resolved
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/auton/Tests/MotorEncoderTest.java Outdated Show resolved Hide resolved
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/auton/Tests/MotorEncoderTest.java Outdated Show resolved Hide resolved
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/auton/Tests/MotorEncoderTest.java Outdated Show resolved Hide resolved
@sadie-datoo sadie-datoo requested review from RZW-13 and Picklze1 January 9, 2024 23:22
Picklze1
Picklze1 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@Picklze1 Picklze1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

TeamCode/src/main/java/org/firstinspires/ftc/teamcode/auton/Tests/MotorEncoderTest.java Show resolved Hide resolved
@sadie-datoo sadie-datoo requested a review from Picklze1 January 18, 2024 04:07
RZW-13
RZW-13 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@RZW-13 RZW-13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads up, some of the formatting is a little off (ctrl+alt+L to do auto formatting in andriod studios), but it looks good for the most part. Nice work!

@sadie-datoo sadie-datoo merged commit e66d982 into master Jan 18, 2024
@sadie-datoo sadie-datoo deleted the sadie-motor-encoders-test branch January 18, 2024 04:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Picklze1 Picklze1 Picklze1 approved these changes

@RZW-13 RZW-13 RZW-13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sadie-datoo @RZW-13 @Picklze1