Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Tele Op base and CR servo tests fixed #57

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Tele Op base and CR servo tests fixed #57

merged 5 commits into from
Dec 6, 2023

Conversation

Picklze1
Copy link
Contributor

@Picklze1 Picklze1 commented Dec 6, 2023

Changes

  • Added full teleOp
  • Edited intake

@Picklze1 Picklze1 marked this pull request as draft December 6, 2023 02:47
@RZW-13 RZW-13 marked this pull request as ready for review December 6, 2023 02:50
@RZW-13 RZW-13 marked this pull request as draft December 6, 2023 02:50
@Picklze1 Picklze1 marked this pull request as ready for review December 6, 2023 06:32
RZW-13
RZW-13 suggested changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@RZW-13 RZW-13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost all of those comments are just suggestions. Still look through them though.
Only stuff I care about you fixing:
Spelling
Add a telemetry statement at the beginning of loop() listing out controls

TeamCode/src/main/java/org/firstinspires/ftc/teamcode/teleop/TeleOp.java Show resolved Hide resolved
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/teleop/TeleOp.java Show resolved Hide resolved
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/teleop/TeleOp.java Outdated Show resolved Hide resolved
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/teleop/TeleOp.java Outdated Show resolved Hide resolved
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/teleop/TeleOp.java Show resolved Hide resolved
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/teleop/TeleOp.java Outdated Show resolved Hide resolved
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/teleop/TeleOp.java Show resolved Hide resolved
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/teleop/TeleOp.java Show resolved Hide resolved
RZW-13
RZW-13 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@RZW-13 RZW-13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! There's a couple changes that you can make if you want, but it's fine if you don't. Awesome job :)

TeamCode/src/main/java/org/firstinspires/ftc/teamcode/teleop/TeleOp.java Outdated Show resolved Hide resolved
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/teleop/TeleOp.java Show resolved Hide resolved
@Picklze1 Picklze1 merged commit c8df862 into master Dec 6, 2023
@Picklze1 Picklze1 deleted the George-Jensen-Teli-Op branch December 6, 2023 16:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RZW-13 RZW-13 RZW-13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Picklze1 @RZW-13