Convert max effects to normal move effects #6143
Conversation
|
Ready for review. Note: the function for move effects is getting bigger and bigger so I think it would make sense to turn it into a function table but should be a separate PR |
| #define MOVE_EFFECT_TERA_BLAST 78 | ||
| #define MOVE_EFFECT_ORDER_UP 79 | ||
| #define MOVE_EFFECT_ION_DELUGE 80 | ||
| #define MOVE_EFFECT_AROMATHERAPY 81 // No functionality yet |
There was a problem hiding this comment.
Since you implemented MOVE_EFFECT_AROMATHERAPY, can you take the chance to apply it to Sparkly Swirl?
(non-blocking)
There was a problem hiding this comment.
can I do it in a follow up pr? I don't want to write a test right now.
| case MAX_EFFECT_EFFECT_SPORE_FOES: | ||
| case MAX_EFFECT_YAWN_FOE: | ||
| case MOVE_EFFECT_EFFECT_SPORE_FOES: | ||
| case MOVE_EFFECT_YAWN_FOE: |
There was a problem hiding this comment.
Should MOVE_EFFECT_SLEEP be added here too?
There was a problem hiding this comment.
I don't know. Idr but I think there was a reason why it wasn't added here but we would need to ask Pawkkie. I would say this is out of scope in this pr though
| case MOVE_EFFECT_LOWER_ATTACK: | ||
| case MOVE_EFFECT_LOWER_DEFENSE: | ||
| case MOVE_EFFECT_LOWER_SPEED: | ||
| case MOVE_EFFECT_LOWER_SP_ATK: | ||
| case MOVE_EFFECT_LOWER_SP_DEF: |
There was a problem hiding this comment.
All of these effects affect both opponents, so they should at least have the _FOES suffix
Converted Max Move Effects to normal Move Effects so they can be used for all moves.