Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Powder (status) config and some terrain timers not using gBattleTurnCounter #6109

Merged
merged 7 commits into from
Jan 26, 2025

Conversation

PhallenTree
Copy link

@PhallenTree PhallenTree commented Jan 26, 2025

  • Fixes B_POWDER_RAIN not working properly after the AtkCanceller got reordered. (Atk Canceller refactor / reorder / clean up #5885)

  • Fixes some terrain timers not using gBattleTurnCounter, causing setup terrains staying on the field for less turns or to last much longer than they should.

  • Fixes gBattleTurnCounter being reset at the end of first turn events instead of at the start of it (caused timers to be set using the previous battle's gBattleTurnCounter).

  • Fixes a typo on unburdenActive.

  • Fixes typos on TryInitializeTrainerSlide functions.

Discord contact info

PhallenTree

src/battle_util.c Outdated Show resolved Hide resolved
Copy link
Collaborator

@AlexOn1ine AlexOn1ine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All regressions caused by me, very cool.

Thank you!

@AlexOn1ine AlexOn1ine merged commit 4158f92 into rh-hideout:upcoming Jan 26, 2025
1 check passed
@AlexOn1ine AlexOn1ine added category: battle-mechanic Pertains to battle mechanics bugfix Bugfixes labels Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bugfixes category: battle-mechanic Pertains to battle mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants