Add known failing learnset cap test #6046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a known failing test that proves #5633 and moves
MAX_RELEARNER_MOVESfor that purpose outside of the move relearner file.#5633 refers to
MAX_LEVEL_UP_MOVESandMAX_RELEARNER_MOVESbeing too low for the level up learnsets that come preshipped with expansion, leading to unexpected behaviour. Both defines are actively used in EWRAM context (MAX_RELEARNER_MOVESnatively, which is why it's capped, andMAX_LEVEL_UP_MOVESin the HGSS dex), so enlarging them comes with memory consequences that need to be carefully reviewed. This PR does not include a fix, only a test that will prove that a hypothetical fix is correct.Discord contact info
bassoonian