forked from DizzyEggg/pokeemerald
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pret merge (17 of January) #6045
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed an extra are
Update vars.h (cleanup)
missing const in extern gBasicHitSplatSpriteTemplate
extern gAncientPowerRockSpriteTemplate fix
remove undef TASK_NONE from list_menu
Fix CaveTransition pals
Replace the magic number opcodes in field script command macros with these new constants
* Missing bard song limit constants * Index bard sound arrays with word constants * Document bard music
Ready for review! |
AlexOn1ine
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pret merge - DO NOT SQUASH!
Description
Conflicts:
event.inc
script_cmd_table.inc
mauville_old_man.c
bard_music/moves.h
bard_music/pokemon.h
Discord contact info
bassoonian