fixed bug giving immunity to full-paralysis when B_MAGIC_GUARD is >= GEN_4 #6032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix a bug reproducible by setting `B_MAGIC_GUARD` to `GEN_3` or lower. I'm pretty sure the previous logic made it so, if your ability is NOT magic guard, you get full-paralysis immunity. My approach isn't ideal as `RNG_PARALYSIS` will now needlessly roll, but I wrote this fix for personal use and figured it couldn't hurt.
|
what was the bug? |
|
You know how you can get immobilized by paralysis? If you have Shouldn't be much harder than that to replicate the bug, I tried it on a clean build. |
|
To avoid running the random calls you can just replace the previous line with |
|
updated, should I do #5990 while I'm at it? |
ye, that would be nice |
|
I think that's all the references to |
AlexOn1ine
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should fix a bug reproducible by setting
B_MAGIC_GUARDtoGEN_3or lower.My approach isn't ideal as
RNG_PARALYSISwill now needlessly roll, but I wrote this fix for personal use and figured it couldn't hurt.Feel free to test.
disc
47929991024