Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mega Evolution, Primal Reversion, and Ultra Necrozma overworld sprites #5874

Merged

Conversation

khbsd
Copy link

@khbsd khbsd commented Dec 24, 2024

Description

Adds Mega Evolution, Primal Reversion, and Ultra Necrozma overworld sprites.

Images

image
image

People who contributed to this PR:

  • @kittenchilly, re-indexing the shiny palettes (by hand! 😱) so they match up with the sprites, adding Ultra Necrozma, and cleaning up unused spritesheets

Mega Evolution Sprite Credits:

^This section has been added to a new CREDITS.md file as well.

Feature(s) this PR does NOT handle:

kittenchilly will be handling these later in a separate PR.

  • Dynamax overworld sprites
  • Gigantamax overworld sprites

Discord contact info

@khbsd

@hedara90 hedara90 added category: pokemon Pertains to Pokémon data and functionality category: overworld Pertains to out-of-battle mechanics labels Dec 30, 2024
@khbsd khbsd marked this pull request as ready for review January 25, 2025 21:29
Copy link
Collaborator

@AsparagusEduardo AsparagusEduardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-only review for now.

If it's ready to review, please update the description, as it's still mentioning it's a WIP branch.

ALso, I see that you're handling Ultra Necrozma data too. Will you handle other battle form changes? If not, please add a ## Feature(s) this PR does NOT handle: section to the PR's description to clarify this.

README.md Outdated Show resolved Hide resolved
src/data/pokemon/species_info/gen_1_families.h Outdated Show resolved Hide resolved
src/data/pokemon/species_info/gen_1_families.h Outdated Show resolved Hide resolved
src/data/pokemon/species_info/gen_1_families.h Outdated Show resolved Hide resolved
src/data/pokemon/species_info/gen_4_families.h Outdated Show resolved Hide resolved
@khbsd khbsd changed the title Add mega evolution overworld sprites Add Mega Evolution, Primal Reversion, and Ultra Necrozma overworld sprites Jan 28, 2025
Copy link
Collaborator

@AsparagusEduardo AsparagusEduardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished checking the sprites on the visualizer, look good to me :)

@AsparagusEduardo AsparagusEduardo merged commit 4fc5612 into rh-hideout:upcoming Jan 31, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: overworld Pertains to out-of-battle mechanics category: pokemon Pertains to Pokémon data and functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants