Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows you to recursivley parse directories and only operates on pyth… #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ben-hearn-sb
Copy link

@ben-hearn-sb ben-hearn-sb commented Apr 19, 2017

Fixes windows newlines also. Changed \n to \r\n
Only runs and modifies python files.
Copies all files not just py files to new target directory to account for icons, binaries etc.

Note:

I modified this and ran it on my project and it worked well.
The code has been modified to only change .py files, copy all file types to new locations and also to not add spaces between python lines

  • Ben

…on files. Copies all files not just py files to new target directory to account for icons, binaries etc.
@Hnasar
Copy link
Contributor

Hnasar commented May 2, 2017

Not all people want windows newlines. Most git projects default to unix newlines. Perhaps a switch could be added but changing all the outputs isn't great.

I do like your commit to recursively parse directories though. If I was maintainer (which I am not) I would ask that you submit a commit with with only the changes from d5c7f86 (in your repo) and without the changes to the newlines.

@rferrazz
Copy link
Owner

rferrazz commented May 3, 2017

I have the same feeling of @Hnasar, could you just submit a pull request with recursive parsing?

@ben-hearn-sb
Copy link
Author

Fair point. The recursive directories I am glad you guys like though

@thorade thorade mentioned this pull request May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants