Fix array-based className handling to avoid comma separation in child elements #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! First, thanks so much for all the work required to build and maintain this library.
When integrating it into my blog, I noticed that class names were not being applied correctly. Specifically, when child elements receive an array of class names (e.g.,
["hljs-title", "function_"]
), React currently renders them as a comma-separated string ("hljs-title,function_"
), which brakes CSS. This issue can be seen on the provided demo page as well:This PR ensures that any
className
arrays are joined with spaces ("hljs-title function_"
) instead.Changes
mapChild
function checks ifprops.className
is an array, and if so, joins it with a space.