chg: fix linting

.gitignore

@@ -1,6 +1,5 @@
 .env*
 dist/*
-**/bindata.go
 .reward/*
 .reward.yml
 

.golangci.yml

@@ -1,12 +1,13 @@
 run:
   concurrency: 8
   tests: true
-  skip-files:
-    - internal/bindata.go
-    - docs/*
   allow-parallel-runners: true
   modules-download-mode: readonly
 
+issues:
+  exclude-files:
+    - docs/*
+
 linters:
   # please, do not use `enable-all`: it's deprecated and will be removed soon.
   # inverted configuration with `enable-all` and `disable` is not scalable during updates of golangci-lint
@@ -15,29 +16,16 @@ linters:
     # https://github.com/golangci/golangci-lint/issues/2649
     - bodyclose
     - contextcheck
-    - interfacer
     - nilerr
     - noctx
     - rowserrcheck
     - sqlclosecheck
-    - structcheck
     - tparallel
     - wastedassign
     # BUG END
-    # DEPRECATED START
-    - deadcode
-    - exhaustivestruct
-    - golint
-    - ifshort
-    - maligned
-    - nosnakecase
-    - scopelint
-    - varcheck
-    # DEPRECATED END
     # IGNORED START
     - gci                # sort imports in a so-so way. use goimports instead
     - gochecknoglobals   # we use some global variables
-    - goerr113           # not useful
     - nonamedreturns     # named returns are our friends
     - gomnd              # false positives for file permissions
     - testpackage        # using
@@ -80,7 +68,6 @@ linters:
     - errchkjson
     - errname
     - errorlint
-    - execinquery
     - exhaustive
     - exportloopref
     - forbidigo

internal/compose/dockercompose_test.go

@@ -53,6 +53,7 @@ func (suite *DockerComposeTestSuite) TestClient_Version() {
 				if tt.optional && errors.Is(err, exec.ErrNotFound) {
 					t.Skipf("skipping test: %s", err)
 				}
+
 				t.Errorf("Version() error = %s, wantErr %t", err, tt.wantErr)
 
 				return
@@ -261,6 +262,7 @@ func (suite *DockerComposeTestSuite) TestClient_RunCommand() {
 				if tt.optional && errors.Is(err, exec.ErrNotFound) {
 					t.Skipf("skipping test: %s", tt.name)
 				}
+
 				t.Errorf("RunCommand() error = %s, wantErr %t", err, tt.wantErr)
 
 				return

internal/docker/docker_test.go

@@ -43,6 +43,7 @@ func (suite *DockerTestSuite) TestClient_dockerVersion() {
 				if tt.optional && dockerpkg.IsErrConnectionFailed(err) {
 					t.Skipf("skipping test: %s", err)
 				}
+
 				t.Errorf("dockerVersion() error = %s, wantErr %t", err, tt.wantErr)
 
 				return
@@ -84,9 +85,11 @@ func (suite *DockerTestSuite) TestClient_isMinimumVersionInstalled() {
 				if c.isMinimumVersionInstalled() == tt.want {
 					return true
 				}
+
 				if tt.optional {
 					t.Skipf("skipping test: %s", tt.name)
 				}
+
 				return false
 			}, "isMinimumVersionInstalled() = %t, want %t", c.isMinimumVersionInstalled(), tt.want)
 		})
@@ -123,6 +126,7 @@ func (suite *DockerTestSuite) TestClient_Check() {
 				if tt.optional {
 					t.Skipf("skipping test: %s", err)
 				}
+
 				assert.Failf(t, "Check() error = %s, wantErr %s", err.Error(), tt.wantErr)
 			}
 		})

internal/shell/shell_test.go

@@ -111,6 +111,7 @@ func (suite *ShellTestSuite) TestLocalShell_Execute() {
 				if tt.optional && errors.Is(err, exec.ErrNotFound) {
 					t.Skipf("Skipping optional test. Error: %s", err)
 				}
+
 				t.Errorf("Execute() error = %s, wantErr %t", err, tt.wantErr)
 
 				return