Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Switch to JingMatrix/LSPatch to resolve patching on Android 15 #10

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

Ushie
Copy link

@Ushie Ushie commented Nov 11, 2024

No description provided.

@oSumAtrIX
Copy link
Member

Please mention the source of these binary blobs.

@Ushie
Copy link
Author

Ushie commented Nov 12, 2024

All the files originate from this action build: https://github.com/JingMatrix/LSPatch/actions/runs/11613450774/artifacts/2128595422

The .jar was converted to .aar with the convert-lspatch.sh script in this repository, and the liblspatch.so binaries were extracted from the manager.apk in that artifact

@oSumAtrIX
Copy link
Member

I don't like the lack of audibility since we are committing binary blobs with no public workflow that generated them, essentially trusting you. Is it possible, to publicly generate the files you're committing?

@oSumAtrIX oSumAtrIX marked this pull request as draft November 20, 2024 18:17
@Ushie
Copy link
Author

Ushie commented Nov 24, 2024

You might've missed my previous comment, the binary blobs checked into this PR are verifiable against the hashes of the workflow I linked

@oSumAtrIX oSumAtrIX marked this pull request as ready for review November 24, 2024 22:10
@Ushie Ushie changed the title chore: Bump LSPatch fix: Switch to JingMatrix/LSPatch to resolve patching on Android 15 Nov 24, 2024
@oSumAtrIX oSumAtrIX merged commit 343a91d into dev Nov 24, 2024
1 check passed
@oSumAtrIX oSumAtrIX deleted the chore/bump-lspatch branch November 24, 2024 22:12
github-actions bot pushed a commit that referenced this pull request Nov 24, 2024
## [1.0.1-dev.1](v1.0.0...v1.0.1-dev.1) (2024-11-24)

### Bug Fixes

* Switch to JingMatrix/LSPatch to fix patching on Android 15 ([#10](#10)) ([343a91d](343a91d))
github-actions bot pushed a commit that referenced this pull request Jan 16, 2025
# [1.1.0](v1.0.0...v1.1.0) (2025-01-16)

### Bug Fixes

* Display correct group status in between steps ([706a547](706a547))
* Switch to JingMatrix/LSPatch to fix patching on Android 15 ([#10](#10)) ([343a91d](343a91d))

### Features

* Cleanup about page and remove previous team members ([39ee2c6](39ee2c6))
* Implement automatic mirror switching and fix handling of stalled downloads ([#14](#14)) ([9921793](9921793))
* Temporarily use DEFAULT if SHIZUKU permissions are not granted ([#15](#15)) ([f784bf6](f784bf6))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants