Add $_GET['q']

[darrenoh]

Fixes #111.

[mglaman]

From RouteProvider:

    $cid = $this->getRouteCollectionCacheId($request);
    if ($cached = $this->cache->get($cid)) {
      $this->currentPath->setPath($cached->data['path'], $request);
      $request->query->replace($cached->data['query']);
      return $cached->data['routes'];
    }
    else {
      // Just trim on the right side.
      $path = $request->getPathInfo();
      $path = $path === '/' ? $path : rtrim($request->getPathInfo(), '/');
      $path = $this->pathProcessor->processInbound($path, $request);
      $this->currentPath->setPath($path, $request);

So the current path is set when the route collection is resolved for the request. So we should remove the constructor logic.

[mglaman]

This is the same logic as the parent, isn't it? It seems more likely that we just need setPath to be

$_GET['q'] = $request->getPathInfo();

[darrenoh]

It's not the same logic as the parent. Here we are working with a reference to $_GET['q'] so if D7 code changes $_GET['q'] it will also change D10’s current path.

[mglaman]

A question, just making sure I understand. Is the complexity to allow manipulating $_GET['q] by reference in code? I thought the PR would entail just overriding setPath to do $_GET['q'] = $path