Fix user roles #101
Merged
Fix user roles #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrenoh
force-pushed
the
fix-user_roles
branch
2 times, most recently
from
d067d7b to
94fce30
Compare
mglaman
reviewed
Nov 23, 2023
|
|
||
| function user_role_load(string $rid): ?RoleInterface | ||
| { | ||
| return Role::load($rid); |
There was a problem hiding this comment.
Can we use long-form \Drupal::entityTypeManager()->getStorage('user_role')->load($rid);
There was a problem hiding this comment.
We could. I actually like the simplicity of letting this static method do it for us. Every entity class has a static load method.
https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21EntityInterface.php/function/EntityInterface%3A%3Aload/10
There was a problem hiding this comment.
For clarity I changed this to use our extended Role class.
darrenoh
force-pushed
the
fix-user_roles
branch
2 times, most recently
from
99b9d28 to
c611e42
Compare
darrenoh
force-pushed
the
fix-user_roles
branch
4 times, most recently
from
0fc65c9 to
379f7d9
Compare
darrenoh
force-pushed
the
fix-user_roles
branch
from
379f7d9 to
6f41864
Compare
darrenoh
force-pushed
the
fix-user_roles
branch
from
6f41864 to
10f002c
Compare
mglaman
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.