add pkg_commands.d file for centos #259
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p3ck
reviewed
Mar 29, 2022
StykMartin
reviewed
Mar 29, 2022
BeeGrech
commented
Mar 29, 2022
plugins/pkg_commands.d/centos
Outdated
| RSTRNT_PKG_CMD=${RSTRNT_PKG_CMD:-rpm-ostree} | ||
| RSTRNT_PKG_CMD=${RSTRNT_PKG_ARGS:-A --idempotent --allow-inactive} | ||
| else | ||
| RSTRNT_PKG_CMD=${RSTRNT_PKG_CMD:-dnf} |
There was a problem hiding this comment.
Actually, i think this 'else' can be dropped, because default is yum. which is supported on centos by default. Which im guessing is the reason this has never been added
BeeGrech
force-pushed
the
add-centos-pkg-command
branch
from
ed06267 to
6c8fd69
Compare
BeeGrech
force-pushed
the
add-centos-pkg-command
branch
from
8789a54 to
23fd9ac
Compare
BeeGrech
force-pushed
the
add-centos-pkg-command
branch
from
23fd9ac to
6f2082a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stream os-tree deployment is not able to support yum/dnf install of packages.
Still blocked by soft dependency install through restraint, as restraint sees the rpm-ostree error as a failure.