Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speeding up check_windspeed_drift (test mean 980us -> 482us) #43

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

speeding up check_windspeed_drift (test mean 980us -> 482us) #43

wants to merge 4 commits into from

Conversation

gabrielecalvo
Copy link
Collaborator

@gabrielecalvo gabrielecalvo commented Jan 13, 2025 •
edited
Loading

Speeding up execution by avoiding copy and keeping only needed data around.

The time has been cut to half from:

------------------------------------------------------------- benchmark: 1 tests ------------------------------------------------------------
Name (time in us)                         Min         Max      Mean    StdDev    Median       IQR  Outliers  OPS (Kops/s)  Rounds  Iterations
---------------------------------------------------------------------------------------------------------------------------------------------
test_calc_rolling_windspeed_diff     830.3000  2,590.3000  980.2053  230.7853  900.2000  133.6000     23;23        1.0202     206           1
---------------------------------------------------------------------------------------------------------------------------------------------

to

------------------------------------------------------------ benchmark: 1 tests ------------------------------------------------------------
Name (time in us)                         Min         Max      Mean    StdDev    Median      IQR  Outliers  OPS (Kops/s)  Rounds  Iterations
--------------------------------------------------------------------------------------------------------------------------------------------
test_calc_rolling_windspeed_diff     369.5000  1,267.7000  425.4475  104.1946  390.4500  30.1000     31;54        2.3505     362           1
--------------------------------------------------------------------------------------------------------------------------------------------

@gabrielecalvo gabrielecalvo requested a review from aclerc January 13, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclerc aclerc Awaiting requested review from aclerc aclerc is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gabrielecalvo