Add cucumber4 support fixes #90 #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the ssl context was clearing out the authorization bearer http header. Now fixed.
Making use of attach_to_launch to allow individual executions of cucumber for each feature file wasn't working. Looks like perhaps this plugin hasn't been updated in line with the API?
It looks like this has possibly changed in the API over time? the existing values are rejected by the server as being invalid. I've simply changed them to "valid" locator values from an almost vanilla docker-compose instance. But I'm not sure if this should really be using statically included strings at all, but rather using ones specified in the report_portal.yml or scenario tags instead? I'll leave this one for the project maintainers to ponder
If cucumber is invoked with multiple formatters, our formatter may be given the path to a file for output as opposed to being given STDOUT
Refactored report.rb to extract retrieval of information about features/scenarios from a dependency injected class extractor Extractor is created by a factory method which will return a class appropriate for the current version of cucumber
The use of embed method is deprecated, as is the use of puts Log messages supplied by use of the log method come through to the attach method with an appropriate mime-type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may not necessarily be the "correct" approach, in terms of the ability to support both cucumber 3 and cucumber >= 4
But given the lack of issues reported, I suspect most people who are using the plugin are perhaps still using cucumber3?
Also fixed some small bugs I ran in to along the way due to the unfortunately odd method I'm having to use right now for publishing results, as our existing automation runner executes feature files one by one.