Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly parse Guix VCS snapshots as such #571

Closed
wants to merge 1 commit into from

Conversation

nckx
Copy link

@nckx nckx commented Dec 11, 2021

This should DTRT if repology/repology-updater#920 (comment) is correct.

Because this was missing there are some buggy ignores scattered across the rule set, which this patch can't fix because the problem isn't technical.

@AMDmi3
Copy link
Member

AMDmi3 commented Dec 11, 2021

This shouldn't be necessary because there's the same thing (with limited scope though) in the parser:

https://github.com/repology/repology-updater/blob/master/repology/parsers/parsers/guix.py#L63

Are there some cases where it doesn't work right?

@nckx
Copy link
Author

nckx commented Dec 13, 2021

Interesting, I wasn't aware of that special case.

Are there some cases where it doesn't work right?

I think so but I don't have a good grasp of the entire Repology codebase.

Here, for example, ‘incorrect’ is, well, incorrect: https://repology.org/project/i7z/versions

@AMDmi3
Copy link
Member

AMDmi3 commented Dec 13, 2021

What exactly is incorrect in this case?

@nckx
Copy link
Author

nckx commented Dec 13, 2021

Yeah, I guess that's my question too. This fork is apparently ‘blessed’ by Repology whilst this one is not? Seems arbitrary, is all.

@AMDmi3
Copy link
Member

AMDmi3 commented Dec 13, 2021

The incorrect status is in fact caused by an unrelated rule, neither fork is blessed. In fact 0.28 is much older than 0.27.4, but I guess there's no point in giving preference to any of these as both are inactive, so I'd split them into separate projects.

Are there another questionable cases?

AMDmi3 added a commit that referenced this pull request Dec 13, 2021
AMDmi3 added a commit that referenced this pull request Dec 13, 2021
@AMDmi3 AMDmi3 closed this Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants