Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deeplink handling on all wallets list and recent wallets #3803

Merged
merged 10 commits into from
Feb 5, 2025

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Feb 5, 2025

Description

  • Fixes issue with deeplink handling on all wallets list (no search) and in recent connector item.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Feb 5, 2025

⚠️ No Changeset found

Latest commit: 1d2d458

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tomiir tomiir requested a review from enesozturk February 5, 2025 13:21
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 4:16pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 4:16pm
9 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-ep ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 4:16pm
appkit-basic-ep-example ⬜️ Ignored (Inspect) Feb 5, 2025 4:16pm
appkit-basic-example ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 4:16pm
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 4:16pm
appkit-basic-up-example ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 4:16pm
appkit-vue-solana ⬜️ Ignored (Inspect) Feb 5, 2025 4:16pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Feb 5, 2025 4:16pm
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 4:16pm
vue-wagmi-example ⬜️ Ignored (Inspect) Feb 5, 2025 4:16pm

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 69.06% 20000 / 28958
🔵 Statements 69.06% 20000 / 28958
🔵 Functions 60.63% 1765 / 2911
🔵 Branches 80.83% 3700 / 4577
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit-utils/exports/index.ts 100% 100% 100% 100%
packages/core/src/controllers/ConnectorController.ts 81.5% 97.33% 72.97% 81.5% 39-41, 49-51, 122-123, 138-139, 149-157, 211-231, 251-252
packages/core/src/utils/MobileWallet.ts 95% 83.33% 100% 95% 14
packages/scaffold-ui/src/partials/w3m-all-wallets-list/index.ts 89.52% 88.46% 91.66% 89.52% 67, 94, 108, 121-122, 135-140
packages/scaffold-ui/src/partials/w3m-all-wallets-search/index.ts 93.47% 100% 85.71% 93.47% 71, 89, 92
packages/scaffold-ui/src/partials/w3m-connect-featured-widget/index.ts 22.58% 100% 0% 22.58% 14-17, 20-21, 25-50, 54-55
packages/scaffold-ui/src/partials/w3m-connect-recent-widget/index.ts 94.87% 91.66% 75% 94.87% 56, 59
Generated in workflow #9413 for commit fc82d6c by the Vitest Coverage Report Action

@tomiir tomiir merged commit 5900a70 into main Feb 5, 2025
25 checks passed
@tomiir tomiir deleted the fix/phantom-deeplink branch February 5, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants