Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce JSON response in controller #46

Merged
merged 11 commits into from
Nov 21, 2024
Merged

Introduce JSON response in controller #46

merged 11 commits into from
Nov 21, 2024

Conversation

CuddlyBunion341
Copy link
Contributor

@CuddlyBunion341 CuddlyBunion341 commented Nov 5, 2024 •
edited
Loading

Closes #51

Added JSON responses to translation_files_controller where necessary. Updated stimulus controller to fetch and display fallback translation to improve UX.

@CuddlyBunion341 CuddlyBunion341 self-assigned this Nov 5, 2024
@CuddlyBunion341 CuddlyBunion341 marked this pull request as ready for review November 5, 2024 06:23
@CuddlyBunion341 CuddlyBunion341 requested a review from a team as a code owner November 5, 2024 06:23
coorasse
coorasse requested changes Nov 5, 2024
View reviewed changes
Copy link
Member

@coorasse coorasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to support json for all the controller actions. Also this makes it difficult to judge to the change that you actually wanted to do. Can you maybe isolate the change in its own PR?

app/controllers/moirai/translation_files_controller.rb Show resolved Hide resolved
@CuddlyBunion341 CuddlyBunion341 force-pushed the feature/update-translation-values branch from e7aca67 to 684d9ea Compare November 13, 2024 15:57
@CuddlyBunion341
Refactor translation files controller
4435f85 
Revert "Update json tests"

This reverts commit 7ff1ffdc7e718c75a7297cbdda699bd40c6f81e2.

Refactor controller

Fix specs

Fix linter

Add api test

Update translation_files_controller

Fix linter
@CuddlyBunion341
Update stimulus controller
38a31b5
@CuddlyBunion341
Revert "Refactor translation files controller"
b3b3390 
This reverts commit a8b6bd9.
@CuddlyBunion341
Merge
41111ed
@CuddlyBunion341 CuddlyBunion341 force-pushed the feature/update-translation-values branch from 684d9ea to 41111ed Compare November 13, 2024 16:00
coorasse
coorasse approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@coorasse coorasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I updated one line and merged!

@coorasse coorasse merged commit 5002661 into main Nov 21, 2024
2 checks passed
@coorasse coorasse deleted the feature/update-translation-values branch November 21, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coorasse coorasse coorasse approved these changes

Assignees

@CuddlyBunion341 CuddlyBunion341

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show the original translation when the value is deleted.
2 participants
@CuddlyBunion341 @coorasse