Refactor

renuo · Nov 13, 2024 · aff9ada · aff9ada
1 parent 25111bf
commit aff9ada
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/app/controllers/moirai/translation_files_controller.rb b/app/controllers/moirai/translation_files_controller.rb
@@ -70,16 +70,10 @@ def handle_create
         return
       end
 
-      if translation_params[:value].blank?
+      if translation_params[:value].blank? && request.format.json?
         respond_to do |format|
           format.json do
-            render json: {
-              fallback_translation: get_fallback_translation
-            }
-          end
-          format.html do
-            flash.alert = "Value can't be blank"
-            redirect_back_or_to moirai_translation_file_path(Digest::SHA256.hexdigest(translation_params[:key]))
+            render json: {fallback_translation: get_fallback_translation}
           end
         end
         return

diff --git a/test/controllers/moirai/translation_files_controller_test.rb b/test/controllers/moirai/translation_files_controller_test.rb
@@ -83,7 +83,7 @@ class TranslationFilesControllerTest < ActionDispatch::IntegrationTest
   test "update translation with blank value json" do
     post translation_files_url, params: {translation: {key: "locales.german", locale: "de", value: ""}}, as: :json
     assert_response :ok
-    assert_equal "Deutsch", JSON.parse(response.body)["translation"]
+    assert_equal "Deutsch", JSON.parse(response.body)["fallback_translation"]
   end
 
   test "update translation with non-blank new value" do