Issue-18/Models reinitialized without editable_attributes

[dalvarez2596]

Issue 18

Description

• Found that the problem was associated to the moment the (editable_attributes) was defined and when the models being reloaded In dev mode, so as we reload the models in every change, and because of the dynamic nature of editable attributes, the same were removed during each reload, until we restart the server.
• In order to avoid this behaviour I add the method to_prepare, in order to reload everytime the models got reloaded.

I used these resources :
Initialization-events
Boot load reloadable

How it looks working:

Screen.Recording.2024-11-09.at.8.42.35.PM.mov

[simon-isler]

thank you for looking into it 🙌🏼

I don't really like how we define the editable_attributes so far. IMO there is no need to define it on existing models. I'd prefer a module with a method that returns the editable attributes for a model. This will make it also easier to test, which is essential since this logic is where everything starts :)

I'm currently refactoring it and will create a PR soon :)

[dalvarez2596]

Yeah, honestly, I wasn’t a huge fan of that approach either. I was about to refactor it, but since this was my first open source PR, I wasn't 100% sure about it, so I just did a quick fix to get things running and make sure I could test without breaking stuff. I was actually thinking of using something like the strategy pattern or a factory, but didn’t want to touch a lot of stuff and complicate things too much.

Anyway, if there’s anything I can help with, just let me know! I’m really enjoying contributing to open source and have some free time to jump in on stuff. :).

[simon-isler]

Yeah, honestly, I wasn’t a huge fan of that approach either. I was about to refactor it, but since this was my first open source PR, I wasn't 100% sure about it, so I just did a quick fix to get things running and make sure I could test without breaking stuff. I was actually thinking of using something like the strategy pattern or a factory, but didn’t want to touch a lot of stuff and complicate things too much.

you're welcome to challenge stuff :) if you're unsure about a change you can ask us by opening an issue e.g.

Anyway, if there’s anything I can help with, just let me know! I’m really enjoying contributing to open source and have some free time to jump in on stuff. :).

that sounds great! #19 would be nice, do you want to look into it? I'll update the description just now

[simon-isler]

I made a couple of fixes and refactorings in #31, #32 and #33. I'll therefore close this PR.

[dalvarez2596]

I’ll take a look at the issue and let you know if I have any doubts or concerns. Thanks for adding a description :)
I just tested the PRs you made, and all three of them seem to be working fine. I didn’t find any issues.