-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remark-github-blockquote-alert
to list of plugins
#1298
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1298 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 142 142
=========================================
Hits 142 142 ☔ View full report in Codecov by Sentry. |
Hey @jaywcjlove! This appears to focus on the HTML output and does not modify the markdown? There is one https://github.com/chrisweb/rehype-github-alerts which may suit your needs. |
@ChristianMurphy Oh, I didn't pay attention to it. |
remark-github-beta-blockquote-admonitions is listed already too. What should we do with this PR? @jaywcjlove @ChristianMurphy? |
Both
Therefore, I think
> [!NOTE/笔记]
> Useful information that users should know, even when skimming content. @wooorm So I should only use my own @wooorm @ChristianMurphy I forgot to ask if merging another option would be possible. If not needed, I will close it. |
To summarize, you are saying:
I do wonder about what Christian also asked: would a rehype plugin not be better? And if you’d make it a rehype plugin, then it would be almost the existing |
When I was developing this plugin, I was only aiming to solve the issue in my other package uiwjs/react-markdown-preview#258, and added an internationalization option for another project of mine. I didn't pay attention to If |
That sounds like you are not interested in maintaining your project? 🤔
🤔 That sounds like your project does not match GitHub? It matches GH in some ways, but also matches your own preferences? |
I have contributed to nearly 300 code repositories in the open-source community and published over 500 packages through npm. However, things have been tough lately. I lost my job at the end of last year, and I currently have no income and haven't managed to overcome this situation yet. Recently, someone raised a new issue (#258) in a project, and I noticed that the needed plugins were not listed in the remark and rehype projects. However, I found the solution to this problem to be quite simple, so I started developing a new package to address it. I have contributed 4 plugins to rehype and have been actively maintaining them. I simply feel that if there are two similar plugins, the official preference is to keep only one, and I am willing to abandon my own. |
Yes, I know you’re prolific and contribute a lot! 😊 I appreciate it!
I am sorry to hear that!
Right, good point. I am fine adding this for now. If it becomes unmaintained, or people have problems with the mistmatch between what it does and what they think it does, we can revisit this later! |
remark-github-blockquote-alert
remark-github-blockquote-alert
to list of plugins
Initial checklist
Description of changes
Add
remark-github-blockquote-alert