Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Dump file safety check. #10

Open
xendk opened this issue Feb 7, 2014 · 4 comments
Open

Dump file safety check. #10

xendk opened this issue Feb 7, 2014 · 4 comments

Comments

@xendk
Copy link
Member

xendk commented Feb 7, 2014

For extra safety, we should check that the dump file ends with the "dump completed" line that mysqldump adds.

@kasperg
Copy link
Member

kasperg commented Sep 22, 2014

Does sql-dump not fail when the creating the dump does not complete?

@xendk
Copy link
Member Author

xendk commented Sep 22, 2014

You'd think so, but I've tried getting incomplete dumps out of sql-dump before. I think it was in relation to a particular failure mode of mysqldump.

@kasperg
Copy link
Member

kasperg commented Sep 22, 2014

Perhaps this should be a patch to drush then?

@xendk
Copy link
Member Author

xendk commented Sep 22, 2014

If I could reproduce it these days... Seem to remember that it was something with running out of disk space on the /tmp partition, but I'm not sure. I might also have attempted to fix the issue with a patch I can't find now.

Besides, Drush being Drush and considering what versions of Drush there might be on the production server, I'd rather play it safe and check the dump from Deployotron. Better to have Deployotron catch a bad dump by looking at the file than having some ancient Drush 5.2 on a server quietly munge your safetynet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants