Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Compression of dumps #9

Open
xendk opened this issue Feb 7, 2014 · 3 comments
Open

Compression of dumps #9

xendk opened this issue Feb 7, 2014 · 3 comments

Comments

@xendk
Copy link
Member

xendk commented Feb 7, 2014

SQL dumps tends to be large without compression. We should compress them per default.

@kasperg
Copy link
Member

kasperg commented Sep 22, 2014

Does this require much more than adding --gzip when running sql-dump?

@xendk
Copy link
Member Author

xendk commented Sep 22, 2014

That would compress it, yes, but then omg would break: https://github.com/reload/deployotron/blob/master/deployotron.actions.inc#L826. Secondly it would make #10 more difficult (tailing an uncompressed file is so much more effective).

One way of fixing this and working #10 into it without wasting the diskspace would be to drop --result-file and pipe the dump though awk or sed with a small script that simply prints a magic message to stderr when seeing the "dump completed" line and piping it's output directly to gzip. Then #10 would be fixed by checking that the command outputted the proper magic message, and we'd have a compressed dump.

@xendk
Copy link
Member Author

xendk commented Sep 22, 2014

Actullly, after careful reading of both master and 6.x branch of Drushs implementation of sql-dump, it turns out that run gzip as an extra command on the file afterwards. They only pipe directly to gzip when not using result-file.

So basically, doing the dump, checking the file for completeness and then gzipping isn't worse off that what it's currently doing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants