Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added benchmark execution_benchmark #4

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Conversation

Eagle941
Copy link
Collaborator

@Eagle941 Eagle941 commented Sep 9, 2024

This new benchmark tests the performance to execute an invoke transaction.

@Eagle941 Eagle941 changed the title Added benchmark 'execution_benchmark' Added benchmark execution_benchmark Sep 9, 2024
@Eagle941 Eagle941 force-pushed the execution_benchmark branch from 371f117 to c7ab633 Compare September 9, 2024 02:39
@Eagle941 Eagle941 changed the title Added benchmark execution_benchmark feat: added benchmark execution_benchmark Sep 9, 2024
@Eagle941 Eagle941 force-pushed the execution_benchmark branch from c7ab633 to a10e795 Compare September 9, 2024 02:43
of 'CachedState::add_visited_pcs' with realistic data sizes.
@Eagle941 Eagle941 marked this pull request as ready for review September 16, 2024 23:06
Copy link

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark looks good, but please be careful about comitting changes that are not actually changes; try and keep the PR minimal.

// Proxy pattern.
{
} else {
// Proxy pattern.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nothing change that should not be included.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clippy complained about that

@Eagle941 Eagle941 merged commit 14e6a87 into main Sep 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants