Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update target timeseries minimum collection date #253

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

bsweger
Copy link
Collaborator

@bsweger bsweger commented Jan 7, 2025

Resolves #251

This PR implements changes to minimum sequence collection date that should be included in the time series target data.
Rather than set the minimum date to the nowcast date - 31 days, it will now be the date on which the round's clade list was created - 90 days.

The collection dates used for the oracle-output target data remain unchanged.

@bsweger bsweger requested a review from elray1 January 7, 2025 19:24
@bsweger bsweger changed the title Bs/update timeseries min date/251 update target timeseries minimum collection date Jan 7, 2025
elray1
elray1 previously approved these changes Jan 8, 2025
Copy link
Collaborator

@elray1 elray1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

src/get_target_data.py Outdated Show resolved Hide resolved
@bsweger bsweger merged commit 1920829 into main Jan 8, 2025
1 check passed
@bsweger bsweger deleted the bs/update-timeseries-min-date/251 branch January 8, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust default collection min date for time series target data
2 participants