Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround macOS EMFILE issue during reflex-web production build #4737

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/integration_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ jobs:
poetry run bash scripts/integration.sh ./rx-shout-from-template prod

reflex-web-macos:
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
# if: github.event_name == 'push' && github.ref == 'refs/heads/main'
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -242,6 +242,9 @@ jobs:
run: |
# Check that npm is home
npm -v
ulimit -a
ulimit -n 32768
ulimit -a
poetry run bash scripts/integration.sh ./reflex-web prod
- name: Measure and upload .web size
run:
Expand Down
12 changes: 0 additions & 12 deletions reflex/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@
Default404Page,
wait_for_client_redirect,
)
from reflex.components.core.sticky import sticky
from reflex.components.core.upload import Upload, get_upload_dir
from reflex.components.radix import themes
from reflex.config import environment, get_config
Expand Down Expand Up @@ -876,15 +875,6 @@ def _setup_error_boundary(self):
continue
self._pages[k] = self._add_error_boundary_to_component(component)

def _setup_sticky_badge(self):
"""Add the sticky badge to the app."""
for k, component in self._pages.items():
# Would be nice to share single sticky_badge across all pages, but
# it bungles the StatefulComponent compile step.
sticky_badge = sticky()
sticky_badge._add_style_recursive({})
self._pages[k] = Fragment.create(sticky_badge, component)

def _apply_decorated_pages(self):
"""Add @rx.page decorated pages to the app.

Expand Down Expand Up @@ -1015,8 +1005,6 @@ def get_compilation_time() -> str:
self._validate_var_dependencies()
self._setup_overlay_component()
self._setup_error_boundary()
if config.show_built_with_reflex:
self._setup_sticky_badge()

progress.advance(task)

Expand Down
160 changes: 0 additions & 160 deletions reflex/components/core/sticky.py

This file was deleted.

Loading
Loading