Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert yarn 4.6.0 upgrade #11907

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Revert yarn 4.6.0 upgrade #11907

merged 2 commits into from
Jan 17, 2025

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jan 17, 2025

This reverts #11874 and #11891 to see if that was what caused the versioning issues I had when releasing RW 8.4.3

@Tobbe Tobbe added release:fix This PR is a fix changesets-ok Override the changesets check labels Jan 17, 2025
@Tobbe Tobbe added this to the next-release-patch milestone Jan 17, 2025
@Tobbe Tobbe merged commit 2571b37 into redwoodjs:main Jan 17, 2025
50 of 51 checks passed
@Tobbe Tobbe deleted the tobbe-revert-yarn-4-6 branch January 17, 2025 11:46
Tobbe added a commit that referenced this pull request Jan 17, 2025
@Tobbe Tobbe modified the milestones: next-release-patch, v8.4.5 Jan 17, 2025
Tobbe added a commit that referenced this pull request Jan 17, 2025
@Tobbe
Copy link
Member Author

Tobbe commented Jan 17, 2025

Didn't help 🙁
Still doesn't know to change "workspace:*" to a proper version for cookie-jar and server-store

image

Tobbe added a commit to Tobbe/redwood that referenced this pull request Jan 18, 2025
@Philzen
Copy link
Contributor

Philzen commented Jan 20, 2025

I was surprised to find this in the patch release (although would love to update asap), b/c that would mean we'd also have to update the migration docs (or at least keep a writeup for people to do it in v9).

So i guess this is fine to be re-reverted in main?

@Philzen
Copy link
Contributor

Philzen commented Jan 20, 2025

@Tobbe hit me up if i can support in any other way! I was already curious b/c there were new tags but no release info...

@Tobbe
Copy link
Member Author

Tobbe commented Jan 20, 2025

@Tobbe hit me up if i can support in any other way! I was already curious b/c there were new tags but no release info...

Yeah, sorry about the missing release notes.
Getting a release out was a lot of work. And then realizing it was broken (because of, it turns out, some issue with nx), and finally working around it to get a working release out. That was very many hours of work. At that point I just needed to take a break.
I'll try to generate release notes and get everything nice and tidy again. But not tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants