Added video quality feature #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigaloid
reviewed
Feb 5, 2024
sigaloid
reviewed
Feb 5, 2024
|
This looks great so far! A couple of suggestions with the bitrate there. That being said, I think long-term it would be better to switch to something like dash.js - this is a good stopgap but if you're proficient with JS and want to try your hand, could be a good thing to work on. I'll open an issue for that but we can go forward with this for now |
Co-authored-by: Matthew Esposito <[email protected]>
Co-authored-by: Matthew Esposito <[email protected]>
|
How do I add it into settings to set a default preference for video quality? |
sigaloid
reviewed
Feb 6, 2024
|
Added some slight styling: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May close #41
I have tried adding the quality change feature, it works but with a delay as it waits for the current segment to finish playing. Please check it out and suggest changes.
I also found some repositories related to this. https://github.com/sahilkashyap64/hls and https://github.com/kmoskwiak/videojs-resolution-switcher but they require some more dependencies.