fix: spoiler hover and video size #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pimlie
commented
Jul 30, 2024
pimlie
commented
- Ensures that when you hover over a video spoiler, the post body is also unblurred & vice versa
- Set min size of video player for when the poster image doesn't load due to a 403 or 404 from upstream
pimlie
force-pushed
the
fix-spoiler-hover-and-video-size
branch
from
2dd31a7 to
eb4b1b2
Compare
when the video is not loaded, the size is determined by the poster image. But when the poster image returns a 404, then the video had a size of 0x0
pimlie
force-pushed
the
fix-spoiler-hover-and-video-size
branch
from
eb4b1b2 to
736bf1c
Compare
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.