Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a whole bunch of styling bugs #193

Merged
merged 22 commits into from
Sep 5, 2024
Merged

Conversation

ButteredCats
Copy link
Contributor

@ButteredCats ButteredCats commented Jul 26, 2024

In no particular order this fixes:

  • Subreddit info overflowing on very small screens
  • Posts having an odd right side gap shortly before swapping to the mobile layout
  • The searchbox having a small gap on the right at and below 800px
  • The sort submit button on user profile being too short at and below 480px (new bug introduced in 410872d)
  • The search bar becoming scrollable slightly before swapping to the new mobile layout (new bug introduced in 410872d)
  • Fixed and unfixed navbar options having differently spaces gaps between the content and the navbar
  • Up/downvote numbers overflowing their container when in the extra small mobile layout
  • 🐛 Bug Report: instance info page becomes unreadable if a field is too long #172
  • Search box being slightly skewed offcenter
  • Post flair not lining up with title text
  • Post flair position being inconsistent between feed and inside of post (in the feed it was before the title, in the post it was after, now it appears in front in both)
  • Slight vertical misalignments with text in the footer
  • The footer text being off center in mobile mode
  • The feeds button not appearing on the settings page, changing the size of the header
  • Extra navbar padding on search page

It also removes an unused option for the mobile layout below 480px.

I plan on trying to tackle the odd gaps some pages have when the fixed navbar is enabled but it was becoming to chaotic to try and manage adding these on top of adding that. Added!

@ButteredCats ButteredCats changed the title Fix a whole bunch of mobile styling bugs Fix a whole bunch of styling bugs Jul 26, 2024
@ButteredCats
Copy link
Contributor Author

Currently double checking everything and cleaning up any oddities I encounter, I'll leave another comment when all is good!

@ButteredCats
Copy link
Contributor Author

Alright, I think that's all I've found that needed fixing. Tested it all in both Firefox and Google Chrome in desktop and mobile modes and all seems fine.

@sigaloid
Copy link
Member

sigaloid commented Sep 5, 2024

Thank you so much for this big PR! Never been good with CSS so fixing this was out of my depth but I've run into a number of these before.

@sigaloid sigaloid merged commit db8b92e into redlib-org:main Sep 5, 2024
3 checks passed
@ButteredCats ButteredCats deleted the css_fixes branch September 5, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants