Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create build-artifacts on release #126

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Conversation

Harm133
Copy link
Contributor

@Harm133 Harm133 commented May 31, 2024

Only build artifacts on published release.

As of now the artifacts are never created as the branch must be "main" on line 9 but must not be "main" on line 63.

fixes #71
fixes #74
fixes #122
fixes #132

Only build artifacts on published release
@sigaloid sigaloid merged commit 08e463f into redlib-org:main Jun 2, 2024
3 checks passed
@sigaloid
Copy link
Member

sigaloid commented Jun 2, 2024

Devastatingly simple fix. Thanks

@kevinsumner
Copy link

It appears the Docker builds referenced in the four fixes Issues aren't actually fixed. Building locally, after a fresh pull of main:

~/projects/redlib ‹main›
zsh$ docker build --build-arg TARGET=v0.34.0 .
[+] Building 2.0s (6/7)                                               docker:default
 => [internal] load build definition from Dockerfile                            0.0s
 => => transferring dockerfile: 612B                                            0.0s
 => [internal] load metadata for docker.io/library/alpine:3.19                  0.1s
 => [internal] load .dockerignore                                               0.0s
 => => transferring context: 2B                                                 0.0s
 => CACHED [1/4] FROM docker.io/library/alpine:3.19@sha256:c5b1261d6d3e4307162  0.0s
 => [2/4] RUN apk add --no-cache curl                                           0.9s
 => ERROR [3/4] RUN curl -L https://github.com/redlib-org/redlib/releases/late  1.0s
------
 > [3/4] RUN curl -L https://github.com/redlib-org/redlib/releases/latest/download/redlib-v0.34.0.tar.gz |     tar xz -C /usr/local/bin/:
0.282   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
0.282                                  Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100     9  100     9    0     0     12      0 --:--:-- --:--:-- --:--:--    12
1.000 tar: invalid magic
1.000 tar: short read
------
Dockerfile:7
--------------------
   6 |
   7 | >>> RUN curl -L https://github.com/redlib-org/redlib/releases/latest/download/redlib-${TARGET}.tar.gz | \
   8 | >>>     tar xz -C /usr/local/bin/
   9 |
--------------------
ERROR: failed to solve: process "/bin/sh -c curl -L https://github.com/redlib-org/redlib/releases/latest/download/redlib-${TARGET}.tar.gz |     tar xz -C /usr/local/bin/" did not complete successfully: exit code: 1

If I get time tonight, I'll put in a PR for it.

@kevinsumner
Copy link

kevinsumner commented Jun 3, 2024

Nevermind, that was my own PEBKAC (TARGET is the Rust target). This looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants