Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1024

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Update README.md #1024

merged 2 commits into from
Jan 17, 2025

Conversation

ivarmu
Copy link
Contributor

@ivarmu ivarmu commented Jan 14, 2025

The field user in the gateway_role_user_assignements role is not handling well the id of the user, so, only the user's username is working correctly

Working OK:

ok: [localhost] => (item=Create/Update Role Organization Member | Wait for finish the Roles creation) => {
    "__gateway_role_user_assignments_job_async_results_item": {
        "__gateway_role_user_assignments_item": {
            "object_id": "2",
            "role_definition": "Organization Member",
            "user": "test_user_1"
        },
        "ansible_job_id": "j820885315526.537903",
        "ansible_loop_var": "__gateway_role_user_assignments_item",
        "changed": false,
        "failed": 0,
        "finished": 0,
        "results_file": "/home/ivan/.ansible_async/j820885315526.537903",
        "started": 1
    },
    "ansible_job_id": "j820885315526.537903",
    "ansible_loop_var": "__gateway_role_user_assignments_job_async_results_item",
    "attempts": 1,
    "changed": false,
    "finished": 1,
    "invocation": {
        "module_args": {
            "gateway_hostname": "aap25.iam.lab",
            "gateway_password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "gateway_request_timeout": null,
            "gateway_token": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "gateway_username": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "gateway_validate_certs": false,
            "object_ansible_id": null,
            "object_id": 2,
            "role_definition": "Organization Member",
            "state": "present",
            "user": "test_user_1",
            "user_ansible_id": null
        }
    },
    "results_file": "/home/ivan/.ansible_async/j820885315526.537903",
    "started": 1,
    "stderr": "",
    "stderr_lines": [],
    "stdout": "",
    "stdout_lines": []
}

Failing:

failed: [localhost] (item=Create/Update Role 2 | Wait for finish the Roles creation) => {
    "__gateway_role_user_assignments_job_async_results_item": {
        "__gateway_role_user_assignments_item": {
            "object_id": "1",
            "role_definition": "2",
            "user": "3"
        },
        "ansible_job_id": "j374059080902.537920",
        "ansible_loop_var": "__gateway_role_user_assignments_item",
        "changed": false,
        "failed": 0,
        "finished": 0,
        "results_file": "/home/ivan/.ansible_async/j374059080902.537920",
        "started": 1
    },
    "ansible_job_id": "j374059080902.537920",
    "ansible_loop_var": "__gateway_role_user_assignments_job_async_results_item",
    "attempts": 1,
    "changed": false,
    "finished": 1,
    "invocation": {
        "module_args": {
            "gateway_hostname": "aap25.iam.lab",
            "gateway_password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "gateway_request_timeout": null,
            "gateway_token": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "gateway_username": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "gateway_validate_certs": false,
            "object_ansible_id": null,
            "object_id": 1,
            "role_definition": "2",
            "state": "present",
            "user": "3",
            "user_ansible_id": null
        }
    },
    "msg": "c{'user': 'Provide exactly one of user or user_ansible_id', 'user_ansible_id': 'Provide exactly one of user or user_ansible_id'}",
    "results_file": "/home/ivan/.ansible_async/j374059080902.537920",
    "started": 1,
    "stderr": "",
    "stderr_lines": [],
    "stdout": "",
    "stdout_lines": []
}

What does this PR do?

Fixes the documentation to reflect only the username option, and not the id.

How should this be tested?

I'm testing this manually as part of redhat-cop/aap_configuration_extended#44

Is there a relevant Issue open for this?

Other Relevant info, PRs, etc

N/A

The field `user` in the `gateway_role_user_assignements` role is not handling well the `id` of the user, so, only the user's `username` is working correctly
@ivarmu ivarmu requested a review from a team as a code owner January 14, 2025 13:06
Copy link
Collaborator

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's probably better this way anyways, I don't believe in hard coding ID's

@djdanielsson djdanielsson enabled auto-merge (squash) January 17, 2025 13:59
@djdanielsson djdanielsson merged commit 64f6689 into devel Jan 17, 2025
9 checks passed
@ivarmu ivarmu deleted the ivarmu-patch-1 branch January 20, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants