fix: Return empty list if user email doesnt exists (#2352)

redhat-cop · Jan 15, 2025 · 137cad5 · 137cad5
1 parent 36a429e
commit 137cad5
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/ratings/api/routers/bookmarks.py b/ratings/api/routers/bookmarks.py
@@ -29,7 +29,8 @@ async def bookmarks_get(email: str) -> BookmarkListResponseSchema:
             ]
             return BookmarkListResponseSchema(bookmarks=bookmarks_response)
         else:
-            raise HTTPException(status_code=404, detail="User email doesn't exists") from e 
+            logger.info(f"User email doesn't exists {email}")
+            return BookmarkListResponseSchema(bookmarks=[])
     except Exception as e:
         logger.error(f"Error getting favorite: {e}", stack_info=True)
         raise HTTPException(status_code=500, detail="Error getting favorites") from e