Don't fail if localStorage cannot be used. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if localStorage was not accessible for whatever reason, then the initialization of the extension would fail. This would leave the extension with a #request-list that had no width set and no ability to resize it. This was okay so long as the URLs in the request list were relatively short but for very long URLs the request list would take more than the width of the frame that DevTools made available for it and would thus be unusable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if localStorage was not accessible for whatever reason, then
the initialization of the extension would fail. This would leave the
extension with a #request-list that had no width set and no ability to
resize it. This was okay so long as the URLs in the request list were
relatively short but for very long URLs the request list would take more
than the width of the frame that DevTools made available for it and
would thus be unusable.