Followup to #6922 refactoring after_realm_open into exclude_from_icloud_backup
#6927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
added
the
no-jira-ticket
8 tasks
8 tasks
kraenhansen
force-pushed
the
kh/exclude-from-icloud-backup-followup
branch
from
e4d7aca to
a71f6e7
Compare
gagik
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
That's cool! Pretty sure I heard some users mention to me that they have seen their data "sync" on Flutter as well and from what I can see it's probably also because of iCloud backup (though I think if data is stored in the application support path, that also lets you opt out).
| MOCHA_REMOTE_GREP='icloud' npm run test:ios --workspace @realm/react-native-test-app-tests | ||
| ``` | ||
|
|
||
| In the command above, we're explicitly grepping for the icloud backup tests. |
There was a problem hiding this comment.
Suggested change
| In the command above, we're explicitly grepping for the icloud backup tests. | |
| In the command above, we're explicitly grepping for the iCloud backup tests. |
Closed
kraenhansen
added a commit
that referenced
this pull request
Nov 29, 2024
…cloud_backup` (#6927) * Avoid including realm core headers in platform.hpp * Add tests * Update contrib guide and script to reference integration tests * Add note in the changelog
kraenhansen
added a commit
that referenced
this pull request
Nov 29, 2024
…cloud_backup` (#6927) * Avoid including realm core headers in platform.hpp * Add tests * Update contrib guide and script to reference integration tests * Add note in the changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
For some reason (yet to be determined) referencing the "shared_realm.hpp" from our platform.hpp fails compilation for Node.js on Windows. Instead of sinking more time and effort into locating the root cause and solving it, I refactored the implementation in #6922 to avoid referencing the
SharedRealmfromplatform.hpp.☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessary@realm/devdocsif documentation changes are needed