RDART-1066: Make schema mode for synchronized realms explicit #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
commented
Jul 15, 2024
| @@ -86,7 +86,7 @@ class ConfigHandle extends HandleBase<realm_config> { | |||
| } else if (config is InMemoryConfiguration) { | |||
| realmLib.realm_config_set_in_memory(configHandle.pointer, true); | |||
| } else if (config is FlexibleSyncConfiguration) { | |||
| realmLib.realm_config_set_schema_mode(configHandle.pointer, realm_schema_mode.RLM_SCHEMA_MODE_ADDITIVE_DISCOVERED); | |||
| realmLib.realm_config_set_schema_mode(configHandle.pointer, realm_schema_mode.RLM_SCHEMA_MODE_ADDITIVE_EXPLICIT); | |||
There was a problem hiding this comment.
This is the actual change, the rest is just cleanup of test code that I noticed while running the tests locally.
nirinchev
commented
Jul 15, 2024
Comment on lines
+1961
to
+1966
| test('Local realm can be opened with orphaned embedded objects', () { | ||
| final config = Configuration.local([Car.schema, AllTypesEmbedded.schema], path: generateRandomRealmPath()); | ||
| expect(() => getRealm(config), returnsNormally); | ||
| }); | ||
|
|
||
| baasTest('Sync realm with orphaned embedded objects, throws', (appConfig) async { |
There was a problem hiding this comment.
These are the tests that test the new changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change schema mode to additive explicit. When schema mode is .discovered, orphaned embedded objects are ignored, which causes a "no such table" exception to be called when we try to look up the table metadata.
Related to #1740, but unlikely to have fixed it.