Make realm the default package

realm · Jul 20, 2023 · 10f1914 · 10f1914
1 parent e7a9fe4
commit 10f1914
Show file tree

Hide file tree

Showing 8 changed files with 103 additions and 84 deletions.
diff --git a/parse-release-tag/README.md b/parse-release-tag/README.md
@@ -2,7 +2,7 @@
 
 This action will take a release tag string as input and produce the following output:
 
-1. `package-name`: the name of the package, if set.
+1. `package-name`: the name of the package, or `realm` if not set.
 2. `package-version`: the version string (10.9.8).
 3. `package-version-suffix`: the prerelease suffix of the version tag
 4. `prerelease`: set to `true` if a version suffix (`-<something>`) is appended to the tag.
@@ -18,7 +18,7 @@ For example, the tag "my-package-v42.0.0-alpha.1 would return:
 
 and the tag "v42.0.0" would return:
 ```
-  package-name: undefined
+  package-name: "realm"
   package-version: "42.0.0"
   package-version-suffix: undefined
   prerelease: false
@@ -31,7 +31,7 @@ and the tag "v42.0.0" would return:
   id: parse-release-tag
   uses: realm/ci-actions/andrew/parse-release-tag
   with:
-    releaseTag: ${{ github.workspace }}/CHANGELOG.md
+    release-tag: ${{ github.workspace }}/CHANGELOG.md
 - name: Print result version
   run: |
     echo ${{ steps.parse-release-tag.outputs.package-name }}

diff --git a/parse-release-tag/__tests__/tests.ts b/parse-release-tag/__tests__/tests.ts
@@ -25,7 +25,7 @@ describe("parseReleaseTag", () => {
         const releaseTagWithoutPackage = "v1.0.0";
         const parsedReleaseTagWithoutPackage = parseReleaseTag(releaseTagWithoutPackage);
         expect(parsedReleaseTagWithoutPackage).deep.equal({
-            packageName: undefined,
+            packageName: "realm",
             packageVersion: "1.0.0",
             packageVersionSuffix: undefined,
             prerelease: false,
@@ -34,7 +34,7 @@ describe("parseReleaseTag", () => {
         const releaseTagWithoutPackageWithSuffix = "v1.0.0-alpha.1";
         const parsedReleaseTagWithoutPackageWithSuffix = parseReleaseTag(releaseTagWithoutPackageWithSuffix);
         expect(parsedReleaseTagWithoutPackageWithSuffix).deep.equal({
-            packageName: undefined,
+            packageName: "realm",
             packageVersion: "1.0.0",
             packageVersionSuffix: "-alpha.1",
             prerelease: true,

diff --git a/parse-release-tag/dist/index.js b/parse-release-tag/dist/index.js
diff --git a/parse-release-tag/dist/index.js.map b/parse-release-tag/dist/index.js.map
diff --git a/parse-release-tag/package.json b/parse-release-tag/package.json
@@ -2,13 +2,12 @@
   "name": "parse-release-tag",
   "version": "0.0.1",
   "description": "Parse a release tag into its components",
-  "main": "lib/src/main.js",
+  "main": "dist/index.js",
   "scripts": {
-    "build": "tsc",
+    "build": "ncc build ./src/main.ts --source-map --license licenses.txt",
     "format": "prettier --write src/**/*.ts",
     "format-check": "prettier --check src/**/*.ts",
-    "lint": "eslint src/**/*.ts",
-    "package": "ncc build --source-map --license licenses.txt",
+    "lint": "eslint src/**/*.ts && npx tsc --noEmit",
     "test": "mocha -r ts-node/register '__tests__/**/*.ts'",
     "all": "npm run build && npm run format && npm run lint && npm run package && npm test"
   },

diff --git a/parse-release-tag/src/helpers.ts b/parse-release-tag/src/helpers.ts
@@ -11,7 +11,7 @@ export function parseReleaseTag(releaseTag: string): ParsedReleaseTag {
     if (!result) {
         throw new Error(`Invalid release tag: ${releaseTag}`);
     }
-    const packageName = result[2];
+    const packageName = result[2] ?? "realm";
     const packageVersion = result[3];
     const packageVersionSuffix = result[4];
 

diff --git a/parse-release-tag/src/main.ts b/parse-release-tag/src/main.ts
@@ -1,9 +1,9 @@
-import core from "@actions/core";
+import * as core from "@actions/core";
 import { parseReleaseTag } from "./helpers";
 
 async function run(): Promise<void> {
     try {
-        const releaseTag = core.getInput("releaseTag");
+        const releaseTag = core.getInput("release-tag");
         const parsedReleaseTag = parseReleaseTag(releaseTag);
 
         core.setOutput("package-name", parsedReleaseTag.packageName);

diff --git a/parse-release-tag/tsconfig.json b/parse-release-tag/tsconfig.json
@@ -8,7 +8,7 @@
     "noImplicitAny": true,
     "esModuleInterop": true,
     "experimentalDecorators": true,
-    "skipLibCheck": true,
+    "skipLibCheck": true
   },
   "exclude": ["node_modules"]
 }