Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AB#74702 - Adopt changes in libetpan #89

Merged
merged 4 commits into from
Nov 12, 2024
Merged

AB#74702 - Adopt changes in libetpan #89

merged 4 commits into from
Nov 12, 2024

Conversation

OleksiiShvachenko
Copy link

No description provided.

@OleksiiShvachenko OleksiiShvachenko self-assigned this Nov 11, 2024
@OleksiiShvachenko
Copy link
Author

OleksiiShvachenko commented Nov 11, 2024 •
edited
Loading

Android tests failed due to wrong time, that is not I changed in this PR 🤔
And the same tests works correctly on iOS and macOS
Screenshot 2024-11-11 at 11 23 34

lxbndr
lxbndr previously approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@lxbndr lxbndr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android tests are failing is a known issue. We have no fix atm 😔

foxinushka
foxinushka reviewed Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@foxinushka foxinushka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useAdditionalHeaders - it sounds too abstract for very concrete change when we add X-Attachment-Id.

@OleksiiShvachenko OleksiiShvachenko merged commit 3a92b56 into spark2 Nov 12, 2024
3 of 4 checks passed
@OleksiiShvachenko OleksiiShvachenko deleted the fix/AB-74702-add-additional-headers branch November 12, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxbndr lxbndr lxbndr approved these changes

@foxinushka foxinushka Awaiting requested review from foxinushka

Assignees

@OleksiiShvachenko OleksiiShvachenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OleksiiShvachenko @foxinushka @lxbndr