Respect ini settings for file uploads #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsor
reviewed
Dec 8, 2017
| @@ -67,18 +81,29 @@ private function __construct(ServerRequestInterface $request) | |||
| if ($var !== false) { | |||
| $this->maxInputNestingLevel = (int)$var; | |||
| } | |||
|
|
|||
| $this->uploadMaxFilesize = $uploadMaxFilesize === null ? $this->iniUploadMaxFilesize() : (int)$uploadMaxFilesize; | |||
There was a problem hiding this comment.
Does is make sense to also allow a string similar to the ini setting, like "8M"? The conversion logic is already there.
There was a problem hiding this comment.
Good point! I'm not opposed, but would rather look into this in a follow-up PR because this also affects the RequestBodyBufferMiddleware 👍
jsor
reviewed
Dec 8, 2017
|
|
||
| /** | ||
| * @param int|null $uploadMaxFilesize | ||
| */ |
There was a problem hiding this comment.
@param int|null $maxFileUploadsmissing?
jsor
approved these changes
Dec 8, 2017
WyriHaximus
approved these changes
Dec 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the
RequestBodyParserMiddlewarerespects all relevant ini settings for file uploads. In other words, this middleware will now respect the following ini settings:Additionally, two parameters have been added to explicitly configure these settings like this:
I realize that this PR is not exactly trivial. If you want to review this, I would suggest checking out the individual commits.
Builds on top of #268
Resolves / closes #257