Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the way that merge state within useOptimistic demo #7375

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions src/content/reference/react/useOptimistic.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,25 +72,30 @@ import { deliverMessage } from "./actions.js";
function Thread({ messages, sendMessage }) {
const formRef = useRef();
async function formAction(formData) {
addOptimisticMessage(formData.get("message"));
const message = {
key: new Date().getTime(),
text: formData.get("message")
};
addOptimisticMessage(message);
formRef.current.reset();
await sendMessage(formData);
await sendMessage(message);
}
const [optimisticMessages, addOptimisticMessage] = useOptimistic(
messages,
(state, newMessage) => [
...state,
//properly merge state by removing the duplicated message
...state.filter(msg => msg.key !== newMessage.key),
{
text: newMessage,
...newMessage,
sending: true
}
]
);

return (
<>
{optimisticMessages.map((message, index) => (
<div key={index}>
{optimisticMessages.map((message) => (
<div key={message.key}>
{message.text}
{!!message.sending && <small> (Sending...)</small>}
</div>
Expand All @@ -107,9 +112,9 @@ export default function App() {
const [messages, setMessages] = useState([
{ text: "Hello there!", sending: false, key: 1 }
]);
async function sendMessage(formData) {
const sentMessage = await deliverMessage(formData.get("message"));
setMessages((messages) => [...messages, { text: sentMessage }]);
async function sendMessage(message) {
const sentMessage = await deliverMessage(message);
setMessages((messages) => [...messages, sentMessage]);
}
return <Thread messages={messages} sendMessage={sendMessage} />;
}
Expand Down
Loading