breaking change: Make Bind use non-generic IViewFor #3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add BindCommandNonGeneric this is too avoid the request of not changing the existing code, therefore adding to the available options. NOTE: Bind only requires `IViewFor` and `IViewFor<TViewModel>` inherits `IViewFor` therefore would still be a non breaking change if BindCommand were relaxed to IViewFor. add ReactiveUserControlNonGeneric for WinForms
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3677 +/- ##
==========================================
- Coverage 58.49% 58.38% -0.12%
==========================================
Files 158 160 +2
Lines 5775 5774 -1
Branches 1026 1028 +2
==========================================
- Hits 3378 3371 -7
- Misses 2010 2015 +5
- Partials 387 388 +1 ☔ View full report in Codecov by Sentry. |
glennawatson
changed the title
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix for #3644
What is the current behavior?
BindCommand requires a view inherited from
IViewFor<TViewModel>ReactiveUserControlinheritsIViewFor<TViewModel>which requires Generics which WinForms does not work well with.What is the new behavior?
Alter
BindCommandwhere clause relaxing toIViewFor.NOTE: Bind only requires
IViewForandIViewFor<TViewModel>inheritsIViewForthereforeBindCommandis now relaxed toIViewForin the same way as Bind.add
ReactiveUserControlNonGenericfor WinForms inheritsIViewForWhat might this PR break?
API Change
Please check if the PR fulfills these requirements
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
Other information: