Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always render script element as plain HTML #1239

Merged
merged 9 commits into from
Jan 21, 2025

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Oct 31, 2024

Description

Make script elements behave more like plain script elements.

This PR is based off of the work in #1204

This change fixes the following

Checklist

Please update this checklist as you complete each item:

  • Tests have been developed for bug fixes or new functionality.
  • The changelog has been updated, if necessary.
  • Documentation has been updated, if necessary.
  • GitHub Issues closed by this PR have been linked.

By submitting this pull request I agree that all contributions comply with this project's open source license(s).

@Archmonger Archmonger force-pushed the fix-script-rendering branch from be50b13 to f33cc4f Compare January 21, 2025 10:10
@Archmonger Archmonger marked this pull request as ready for review January 21, 2025 11:56
@Archmonger Archmonger merged commit 17f2286 into reactive-python:main Jan 21, 2025
17 checks passed
@Archmonger Archmonger deleted the fix-script-rendering branch January 21, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-major Warrents a major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

script elements can break ReactPy Don't strip Script tag elements
1 participant